Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Move the player backend choice to the options menu #47

Open
lackofbindings opened this issue Nov 5, 2024 · 3 comments

Comments

@lackofbindings
Copy link

The one thing that still bothers me and always takes extra explaining to anyone who uses your player for the first time is the need to hit that checkbox after entering a URL. With how infrequent the need is to change player backend (only when vrchat breaks something with avpro), the choice of player backend should be a "default backend" dropdown in the options cog menu, instead of asking every single time a URL is entered.

@JLChnToZ
Copy link
Owner

JLChnToZ commented Nov 5, 2024

I think that popup is still important as that not only allow you to select player backend (or image loader), also indicates the link you entered will play immediately or enqueued after confirm.

@JLChnToZ
Copy link
Owner

JLChnToZ commented Nov 5, 2024

Also, you can feel free to rearrange the layout as you want.
By design, the UI should still work even you remove that popup completely, the drawback is you just can't select the player backend afterwards.

@JLChnToZ
Copy link
Owner

JLChnToZ commented Nov 5, 2024

Just checked the implementation, you can just do this:

  1. Unpack the UI prefab
  2. Move the whole popup under URL input hierarchy into the UI panel under that cog
  3. Delete the checkbox button
  4. Select UI handler, inside the inspector, delete the reference of "video player select panel" under "URL Input" section (by hitting delete on your keyboard while selecting that property).

It should already work as your requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants