Cli updates #357
Open
Cli updates #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix the LobsterPy tests here first and then add new functionalities? @naik-aakash |
|
Hi @JaGeo , as I have written in the note, it has nothing to do with LobsterPy tests. We have to wait for new release of pymatgen where deprecated method is removed causing failures due to monty warnings See here : materialsproject/pymatgen#4243 |
|
@naik-aakash thank you 😅. I also wrote something in the pymatgen PR |
JaGeo
reviewed
Jan 6, 2025
kaueltzen
suggested changes
Jan 7, 2025
|
Hi @kaueltzen, I have now addressed the review comments. Let me know if anything else needs to be addressed. |
kaueltzen
reviewed
Jan 10, 2025
|
@JaGeo am done, this is ready to be merged imo (: 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #344 and #328
Note: Failing tests in CI are due to the pymatgen depreciation of some methods and have nothing to do with
LobsterPy/ pymatgenLOBSTERparsers/changes in this PR.Todo