Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate BigStream2 #38

Open
krokicki opened this issue Jun 1, 2023 · 4 comments
Open

Integrate BigStream2 #38

krokicki opened this issue Jun 1, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@krokicki
Copy link
Member

krokicki commented Jun 1, 2023

Integrate BigStream2 to replace BigStream1 for registration. Compare results and performance.

@krokicki krokicki converted this from a draft issue Jun 1, 2023
@krokicki krokicki added the enhancement New feature or request label Jun 1, 2023
@JienaL
Copy link

JienaL commented Sep 20, 2023

Hi, just catching up with the work. I am looking forward to the work that replace Bigstream1 with Bigstream2, so I wonder if there is any progress in the intergration? I need to use the following augments in Bigstream2 to obtain a better registration result, so I want to know could I use these augments after integration? Or more specifically, which augments I can set while which augments I can not set? Thank you for your reply in advance.
image
image
image
image
image

@cgoina
Copy link
Collaborator

cgoina commented Sep 21, 2023

Nextflow bigstream registration pipeline is already available in the dev branch and at this point it just needs updated documentation of the new parameters. It currently exposes mostly ransac parameters and some affine_align and deform_align parameters:

ransac params:

  • num_sigma_max
  • cc_radius
  • nspots
  • diagonal_constraint
  • match_threshold
  • align_threshold
  • spot_detection_kwargs
    • threshold
    • threshold_rel
  • blob_sizes

configure_irm params:

  • metric
  • optimizer
  • optimizer_args
    • learning_rate
    • minStep
    • iterations

deform_args:

  • control_point_spacing

Mask parameter is also available

Bigstream has a lot of parameters that can be tweaked and not all of them are immediately obvious. Some of these parameters can really influence the registration result so if you find any that really improved your registration result, which is not listed above please let us know.

@JienaL
Copy link

JienaL commented Sep 23, 2023

Thanks! Apart from the parameters that you mentioned above, we also need to use the following params:

ransac_kwargs:

  • fix_mask
  • mov_mask

affine_kwargs:

  • interpolator
  • shrink_factor
  • smooth_sigmas
  • fix_mask
  • mov_mask
  • metric_args

deform_kwargs:

  • control_point_spacing
  • control_point_level
  • interpolator
  • shrink_factor
  • smooth_sigmas
  • fix_mask
  • mov_mask
  • metric
  • optimizer
  • optimizer_args
  • metric_args

Also, we really need the documentation of the new params to guide us how to set these params correctly. Thank you for your help.

@krokicki
Copy link
Member Author

@GFleishman do you have any documentation for the BigStream parameters that we can add to the EASI-FISH pipeline documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants