Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if git base directory is not the same as android base folder project #7

Open
otusweb opened this issue Mar 12, 2018 · 8 comments

Comments

@otusweb
Copy link

otusweb commented Mar 12, 2018

I'm working on a react native project so my file structure is as follow:

- ios
- android/
    app/
         build.gradle

In the script I set gradle_file_folder to app
while in the android directory => fastlane beta

Result:
I get this error:

Found unexpected uncommited changes in the working directory. Expected these files to have
changed:
app/build.gradle.
But found these actual changes:
android/app/build.gradle.
Make sure you have cleaned up the build artifacts and
are only left with the changed version files at this stage in your lane, and don't touch the
working directory while your lane is running. You can also use the :force option to bypass this
check, and always commit a version bump regardless of the state of the working directory.

@ilyakar
Copy link

ilyakar commented Apr 4, 2018

I have the same error. Makes this plugin unusable if user is making apps with React Native like us.

@controllerdotM
Copy link

This is not only an issue for React Native projects. We build native apps and use a similar file structure where the git repo's base directory is one level above the Android project folder. I am getting the same error and the only way I see around it is to change our file structure...

@davidfrasch
Copy link

davidfrasch commented Apr 12, 2018

I´m working with fastlane and CircleCi and have the same Problem....any ideas what we could do, except changing the file structure?

@AlanLayt
Copy link

For anyone else landing here with the same issue, using app_folder_name instead of gradle_file_folder seems to do the trick.

commit_android_version_bump(
  # gradle_file_folder:"app"
  app_folder_name: "app"
)

@ilyakar
Copy link

ilyakar commented Oct 10, 2018

Works like a charm. Thanks @AlanLayt!

@oklimberg
Copy link
Collaborator

Hi,
I will update the documentation soon, to include this information

@soniyaraj
Copy link

@AlanLayt I am having the same issue but using app folder does not help. Please help

@passmanagerapp
Copy link

@AlanLayt Hi, it is 2023 and still documentation not updated and we get the same error. Any other plugin to help us ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants