-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scipy and PyWavelets optional #217
Comments
What is the motivation behind this? |
Size of Scipy is about 166M. It's too large for my desktop app. |
Would "pip install --no-deps" be a workaround for you? I would prefer imagehash to be as useful as possible by default. |
Yes, no-deps or uninstalling can help with PyWavelets. But I use pHash and whant implementation without scipy |
Would be good to know if the libraries are bit-for-bit / bug-for-bug compatible in their output. |
It would be great to make scipy and PyWavelets dependencies optional:
pip install imagehash[pywt]
orpip install imagehash[scipy]
When scipy is missed we can use numpy implementation of 2D DCT (https://public.websites.umich.edu/~mejn/cp/programs/dcst.py). Also separating DCT function can help with #108.
If you are interested, I can create a PR
The text was updated successfully, but these errors were encountered: