From 5f127a49a1ccb662b51f0e98b731acc1ed9f7c51 Mon Sep 17 00:00:00 2001
From: John Cremona <john.cremona@gmail.com>
Date: Fri, 21 Jun 2024 10:47:30 +0100
Subject: [PATCH] small change to homtest output

---
 README.md                    | 3 ---
 libsrc/egr.cc                | 6 +++---
 tests/homtest.cc             | 2 +-
 tests/out_no_ntl/homtest.out | 2 +-
 tests/out_ntl/homtest.out    | 2 +-
 5 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/README.md b/README.md
index 34660a3f..dd1f065e 100644
--- a/README.md
+++ b/README.md
@@ -7,6 +7,3 @@ eclib
 The eclib package includes mwrank (for 2-descent on elliptic curves
 over Q) and modular symbol code used to create the elliptic curve
 database.
-
-[![Total alerts](https://img.shields.io/lgtm/alerts/g/JohnCremona/eclib.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/JohnCremona/eclib/alerts/)
-[![Language grade: C/C++](https://img.shields.io/lgtm/grade/cpp/g/JohnCremona/eclib.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/JohnCremona/eclib/context:cpp)
diff --git a/libsrc/egr.cc b/libsrc/egr.cc
index d91b7fd9..a92dfb7b 100644
--- a/libsrc/egr.cc
+++ b/libsrc/egr.cc
@@ -258,7 +258,7 @@ int ComponentGroups::gr1prime(vector<Point>& Plist, const bigint& p)
   //  cout<<"regulator = "<<reg0<<endl;
   //  cout<<n<<" points"<<endl;
 #endif
-  if(npts==0) return 1;
+  if(Plist.empty()) return 1;
   Point P0 = Plist[0], P1;
   vector<int> CG = ComponentGroup(p);
   long CGexpo=CG[0];
@@ -368,8 +368,8 @@ int ComponentGroups::gr1prime(vector<Point>& Plist, const bigint& p)
   if(CGOrder==1) return 1;
 #ifdef DEBUG_EGR
   cout<< "processing point #1: "<<flush;
-#endif
-  m=OrderInComponentGroup(P0,p,CG); // will hold current index
+#endif 
+ m=OrderInComponentGroup(P0,p,CG); // will hold current index
   for(j=1; j<npts; j++)
     {
       n0 = m;
diff --git a/tests/homtest.cc b/tests/homtest.cc
index 51fce99d..a752f464 100644
--- a/tests/homtest.cc
+++ b/tests/homtest.cc
@@ -71,7 +71,7 @@ int main(void)
 	cout << plus << ": ";
 	cout << "\tDimension = " << dim;
 	cout << "\tCuspidal dimension = " << cdim;
-	if(d*cd>1) cout<<" denoms ("<<d<<","<<cd<<")";
+	if(d*cd>1 &&verbose) cout<<" denoms ("<<d<<","<<cd<<")";
 #ifdef SHOW_TIMES
 	show_time();
 #endif
diff --git a/tests/out_no_ntl/homtest.out b/tests/out_no_ntl/homtest.out
index 3d1ef47b..9aed5114 100644
--- a/tests/out_no_ntl/homtest.out
+++ b/tests/out_no_ntl/homtest.out
@@ -25,7 +25,7 @@ Sign = -1: 	Dimension = 111	Cuspidal dimension = 111
 Sign =  0: 	Dimension = 229	Cuspidal dimension = 222
 
 >>>Level 905
-Sign =  1: 	Dimension = 92	Cuspidal dimension = 89 denoms (2,2)
+Sign =  1: 	Dimension = 92	Cuspidal dimension = 89
 Sign = -1: 	Dimension = 89	Cuspidal dimension = 89
 Sign =  0: 	Dimension = 181	Cuspidal dimension = 178
 
diff --git a/tests/out_ntl/homtest.out b/tests/out_ntl/homtest.out
index 3d1ef47b..9aed5114 100644
--- a/tests/out_ntl/homtest.out
+++ b/tests/out_ntl/homtest.out
@@ -25,7 +25,7 @@ Sign = -1: 	Dimension = 111	Cuspidal dimension = 111
 Sign =  0: 	Dimension = 229	Cuspidal dimension = 222
 
 >>>Level 905
-Sign =  1: 	Dimension = 92	Cuspidal dimension = 89 denoms (2,2)
+Sign =  1: 	Dimension = 92	Cuspidal dimension = 89
 Sign = -1: 	Dimension = 89	Cuspidal dimension = 89
 Sign =  0: 	Dimension = 181	Cuspidal dimension = 178