Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let a dependency package own collect_as? #81

Open
nsajko opened this issue Jan 11, 2025 · 1 comment
Open

let a dependency package own collect_as? #81

nsajko opened this issue Jan 11, 2025 · 1 comment

Comments

@nsajko
Copy link
Collaborator

nsajko commented Jan 11, 2025

I think it'd be slightly nicer if we let another package (https://github.com/JuliaArrays/CollectAs.jl?) own the collect_as function. That way:

  • third-party packages might want to extend collect_as for their own collection types
  • we wouldn't need to worry about whether to export collect_as or not, if a user wants it, they can do using CollectAs

The FixedSizeArray-specific methods would still be defined here.

@nsajko
Copy link
Collaborator Author

nsajko commented Jan 11, 2025

The CollectAs package on its own would presumably have methods for:

  • Union{}: just throw
  • Array: implemented using collect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant