Jet Version Update #261
Open
Jet Version Update #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Julia version in ci and updated the parse_proto_file function in Parsers.jl to fix issues raised by JET
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 92.99% 92.82% -0.18%
==========================================
Files 25 25
Lines 2812 2814 +2
==========================================
- Hits 2615 2612 -3
- Misses 197 202 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the error thrown by JET versions less than
0.9.12that were previously used in this package, this PR seeks to update the JET version to0.9.12. The change also led to the update of the Julia compat version to 1.10.Having updated JET, an error was detected on the Parsers.jl file where some types being passed to the definitions dictionary in the
parse_proto_filefunction did not contain thenamefield. This PR restricts the types passed to those that have thenamefield; which happen to be the allowed set of types that can be value of the definitions dictionary.These changes make the tests pass, at least locally.