Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow MKL_jll version 2025 #314

Merged
merged 5 commits into from
Jan 22, 2025
Merged

allow MKL_jll version 2025 #314

merged 5 commits into from
Jan 22, 2025

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jan 22, 2025

A new version has been released; see https://github.com/JuliaBinaryWrappers/MKL_jll.jl. We observe some issues resulting from the package manager deciding to use an old version of FFTW.jl that does not impose restrictions on MKL_jll so that the 2025 version can be installed.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.99%. Comparing base (cd4f9b9) to head (271c207).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   70.99%   70.99%           
=======================================
  Files           5        5           
  Lines         531      531           
=======================================
  Hits          377      377           
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Member

You need to remove the x86 jobs with MKL though.

@ranocha
Copy link
Member Author

ranocha commented Jan 22, 2025

Like this, @giordano?

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@ranocha ranocha requested a review from giordano January 22, 2025 18:06
@giordano
Copy link
Member

giordano commented Jan 22, 2025

#314 (comment)

And delete

# 32-bit Linux binary for MKL isn't always available, let's ignore it
- os: ubuntu-latest
provider: 'mkl'
arch: x86

@ranocha
Copy link
Member Author

ranocha commented Jan 22, 2025

Sorry, I didn't see that comment earlier - should be fixed now

@giordano giordano merged commit cefd827 into master Jan 22, 2025
46 checks passed
@giordano giordano deleted the ranocha-patch-1 branch January 22, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants