From c6f97149566b3be1686731fcb45b5c66f88e7262 Mon Sep 17 00:00:00 2001 From: Hendrik Muhs Date: Wed, 15 Jan 2025 17:53:16 +0100 Subject: [PATCH 1/4] run workflow on 24.04 --- .github/workflows/rust.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 3009db456..c493f8d8a 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -11,8 +11,12 @@ env: jobs: build: - - runs-on: ubuntu-22.04 + runs-on: ${{matrix.os}} + name: ${{ matrix.os }} + strategy: + fail-fast: false + matrix: + os: ['ubuntu-22.04', 'ubuntu-24.04'] steps: - uses: actions/checkout@v4 From 1ac8c3d189a7f53472c88c7fb94a29a2bd28417f Mon Sep 17 00:00:00 2001 From: Hendrik Muhs Date: Wed, 15 Jan 2025 21:23:27 +0100 Subject: [PATCH 2/4] add job to check latest dependencies --- .github/workflows/rust.yml | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index c493f8d8a..97bbb5d84 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -11,13 +11,7 @@ env: jobs: build: - runs-on: ${{matrix.os}} - name: ${{ matrix.os }} - strategy: - fail-fast: false - matrix: - os: ['ubuntu-22.04', 'ubuntu-24.04'] - + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v4 - name: Install system packages @@ -30,3 +24,20 @@ jobs: run: cargo build --verbose --manifest-path rust/Cargo.toml - name: Run tests run: cargo test --verbose --manifest-path rust/Cargo.toml + + build_latest_deps: + name: Latest Dependencies + runs-on: ubuntu-latest + continue-on-error: true + env: + CARGO_RESOLVER_INCOMPATIBLE_RUST_VERSIONS: allow + steps: + - uses: actions/checkout@v4 + - name: Install system packages + run: | + sudo apt-get update + sudo apt-get install -y libsnappy-dev libzzip-dev zlib1g-dev libboost-all-dev + - run: rustup update stable && rustup default stable + - run: cargo update --verbose --manifest-path rust/Cargo.toml + - run: cargo build --verbose --manifest-path rust/Cargo.toml + - run: cargo test --verbose --manifest-path rust/Cargo.toml \ No newline at end of file From 0bee02c189d9bee8ead2a3c72d8ee8e4d1dee21d Mon Sep 17 00:00:00 2001 From: Hendrik Muhs Date: Fri, 17 Jan 2025 22:08:47 +0100 Subject: [PATCH 3/4] update bindgen, <0.69 does not produce bindings on ubuntu 24.04 --- rust/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/Cargo.toml b/rust/Cargo.toml index 914b2e6fc..deb28627b 100644 --- a/rust/Cargo.toml +++ b/rust/Cargo.toml @@ -10,7 +10,7 @@ categories = ["data-structures", "algorithms", "external-ffi-bindings", "memory- keywords = ["big-data", "keyvaluestore", "fst", "search"] [build-dependencies] -bindgen = ">=0.58" +bindgen = ">=0.69.5" cmake = ">=0.1" [dependencies] From ad1aaeb39d088c63486de5f2c9e988e013a5ada2 Mon Sep 17 00:00:00 2001 From: Hendrik Muhs Date: Fri, 17 Jan 2025 22:10:07 +0100 Subject: [PATCH 4/4] style fix --- .github/workflows/rust.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 97bbb5d84..47a7fa526 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -40,4 +40,5 @@ jobs: - run: rustup update stable && rustup default stable - run: cargo update --verbose --manifest-path rust/Cargo.toml - run: cargo build --verbose --manifest-path rust/Cargo.toml - - run: cargo test --verbose --manifest-path rust/Cargo.toml \ No newline at end of file + - run: cargo test --verbose --manifest-path rust/Cargo.toml +