Uniformize all sklearn estimator parameters to those of core #321
Labels
Priority/1-Medium
To do after P0
Size/Weeks
Needs some weeks (big)
Status/ReadyForDev
The issue is ready to be developed or to be investigated deeply
Type/Feature
A new feature request or an improvement of a feature
Description
Currently, there are various Khiops parameters that are renamed in the sklearn estimators. Renaming them to their
core
counterpart would simplify the code and ease the transition to thecore
API.Note that these naming conventions come from very early versions of the
sklearn
estimators, when thecore
library was not compliant with the Python naming conventions.This would enable also to eliminate almost all parameter checks in
sklearn
estimators, because the message checks made by core would match the parameter names. So, we can reuse them.Questions/Ideas
n_pairs
->max_pairs
n_trees
->max_trees
n_features
->max_constructed_variables
n_evaluated_features
->max_evaluated_variables
n_selected_features
->max_selected_variables
transform_type_numerical
->numerical_recoding_method
transform_type_categorical
->categorical_recoding_method
transform_type_pairs
->pairs_recoding_method
core
. For example, do not accept anymoredummies
and instead accept0-1 binarization
.build_frequency_vars
->build_frequency_variables
build_distance_vars
->build_distance_variables
build_name_vars
->build_cluster_variable
n_*
vsmax_*
: One can argue that the changes for then_*
parameters make them less sklearn compliant. But themax_*
naming have the proper semantics, as they are the limit on how many pairs/trees/variables can be constructed by Khiops. Also, there aremax_*
parameters in the sklearn library.feature
vsvariable
:sklearn
uses the "feature" semantics whereascore
user "variable". For example many of the attributes in thefit
state usefeature
in their names.The text was updated successfully, but these errors were encountered: