Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-in vtk imports #81

Open
FezVrasta opened this issue Oct 17, 2022 · 3 comments
Open

Remove built-in vtk imports #81

FezVrasta opened this issue Oct 17, 2022 · 3 comments

Comments

@FezVrasta
Copy link
Contributor

Right now this import is importing many heavy assets that are not always necessary.

https://github.com/Kitware/react-vtk-js/blob/master/src/index.js#L2

It'd be great if the library didn't import them and let the consumer import what they need.

@jourdain
Copy link
Collaborator

That would be a tricky one as one of the point of it is to allow direct usage. But maybe that list of import could be managed somewhere here assuming it gets loaded in the proper vtk.js namespace.

@FezVrasta
Copy link
Contributor Author

Maybe you could expose an additional entry point with no auto imports?

import { View } from 'react-vtk-js/light';

@jourdain
Copy link
Collaborator

I like the light version. Let's go with that option then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants