Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/fix default.lua test cases #1250

Closed
white238 opened this issue Oct 24, 2024 · 1 comment · Fixed by #1253
Closed

Enable/fix default.lua test cases #1250

white238 opened this issue Oct 24, 2024 · 1 comment · Fixed by #1253

Comments

@white238
Copy link
Member

white238 commented Oct 24, 2024

These were turned off when we were fixing the input file functionality but can/should be turned back on.

#TODO: Turn these back on when input files work with the new physics modules
# blt_add_test(NAME serac_driver_default
# COMMAND ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/serac -o default -i ${input_files_dir}/default.lua
# NUM_MPI_TASKS 1 )
# blt_add_test(NAME serac_driver_default_parallel
# COMMAND ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/serac -o default_parallel -i ${input_files_dir}/default.lua
# NUM_MPI_TASKS 2 )
# blt_add_test(NAME serac_driver_no_thermal
# COMMAND ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/serac -o default_no_thermal -i ${input_files_dir}/tests/solid/qs_linear.lua
# NUM_MPI_TASKS 1 )
# blt_add_test(NAME serac_driver_no_solid
# COMMAND ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/serac -o default_no_solid -i ${input_files_dir}/tests/heat_transfer/static_solve.lua
# NUM_MPI_TASKS 1 )

The input file also seems to be fundamentally broken with this error (or the error is wrong):

[ERROR (/serac/src/drivers/serac.cpp:223)]
Solid order '1' and thermal order '2'' do not match.
** StackTrace of 5 frames **
Frame 1: axom::slic::logErrorMessage(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int)
Frame 2: getOrder(std::optional<serac::SolidMechanicsInputOptions>, std::optional<serac::HeatTransferInputOptions>, std::optional<serac::ThermomechanicsInputOptions>)
Frame 3: main
Frame 4: __libc_start_main
Frame 5: _start
=====

Also the integration tests have a file globbing problem that needs to be solved to re-enable them (thanks @chapman39 for locating this):

https://github.com/LLNL/serac_tests/blob/662c093dddcff184983547ea0212adce3632a751/integration/test.ats#L231

@chapman39
Copy link
Collaborator

The solid ordering is an issue that arose after updating the input files to handle functional. I remember discussing this with @jamiebramwell but don't remember exactly what the error is about.

In any case, I think it's best to either completely remove the default lua or replace its contents with another currently existing (and working) lua file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants