Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some factory methods for `Domain' don't fully construct valid objects #1272

Closed
btalamini opened this issue Nov 17, 2024 · 1 comment · Fixed by #1275
Closed

Some factory methods for `Domain' don't fully construct valid objects #1272

btalamini opened this issue Nov 17, 2024 · 1 comment · Fixed by #1275
Assignees
@samuelpmishLLNL

Comments

@btalamini
Copy link
Member

The Boolean set operation methods that construct instances of Domain don't fill out all the member variables. The missing ones (the mfem_*_ids_) are needed for getting indices into FiniteElementState instances.

This bug is also present in the EntireDomain and EntireBoundary methods, but I'm about to submit a simple fix for those.
@btalamini btalamini mentioned this issue Nov 18, 2024
Closed
@samuelpmishLLNL samuelpmishLLNL self-assigned this Nov 18, 2024
@samuelpmishLLNL
Copy link
Contributor

I could fix this in its own PR or roll it into the DG one (which is already making some improvements to the Domain class)-- do you have any preference?

@btalamini btalamini mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuelpmishLLNL samuelpmishLLNL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix acquisition of dof lists from Domains LLNL/serac
2 participants
@btalamini @samuelpmishLLNL