-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix acquisition of dof lists from Domains #1275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where not all members of the class were being constructed, leaving the object in an invalid state. In particular, the mfem id vectors (like mfem_edge_ids_) were not populated, making it impossible to get lists of dofs on the domain.
…ay valid Makes it less likely that a user will populate some of the required lists but not others.
tupek2
reviewed
Nov 22, 2024
tupek2
approved these changes
Nov 22, 2024
…, address doxygen warnings
/style |
samuelpmishLLNL
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two sets of books in
Domain
:Functional
to identify entities that should be integrated over.mfem::Mesh
data structure?" (which does not segregate by element geometry). These are used to be able to grab dofs that live on aDomain
.As noted in #1272, some of the factory methods and operators on
Domain
did not populate all the required data. The omissions were the second group, the global element data, so grabbing dofs were broken in some cases.Fundamentally, this class should enforce that every time an entry is added to the first group, a corresponding entry is also added to the second. That's an interface-breaking change I don't want to undertake now. I fixed the bug and moved the class one step closer to the ideal by adding
addElement(...)
andaddElements(...)
methods that require both indices to be supplied at once. In sum this PR does the following:addElement(...)
andaddElements(...)
methods, which fixes the bug, and sets a pattern that makes it less likely a modifier of this class will do the wrong thing.Fixes #1272.