Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect type in some boolean operations on Domain #1286

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

btalamini
Copy link
Member

The type_ attribute of Domain, which tracks whether the domain is of boundary elements or bulk elements, was not being set for domains created from Boolean operations. The type should have passed from the operands to the created Domain (and the operator should check that both operands have matching type).

This PR does the following:

  • adds tests that detect the bug
  • removes the default value for the type_ attribute in the constructor, forcing each of the factory functions to explicitly set it
  • fixes the bug, and puts in the missing type_ check.

Fixes #1281

@btalamini
Copy link
Member Author

/style

@btalamini btalamini merged commit d4aacdc into develop Dec 6, 2024
2 checks passed
@btalamini btalamini deleted the talamini/bugfix/domain_element_type branch December 6, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boundary domains created with set operations have the wrong type
3 participants