Only error when invalid maps are passed to base physics methods #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… empty to allow end users to use in common interface in more cases.
|
/style |
btalamini
approved these changes
Dec 23, 2024
src/serac/physics/base_physics.hpp
Outdated
| { | ||
| SLIC_ERROR_ROOT(axom::fmt::format("Adjoint analysis not defined for physics module {}", name_)); | ||
| if (string_to_dual.size()) { |
There was a problem hiding this comment.
If you're checking whether the map is populated here, I suggest using the empty() method on STL containers, because the intent is clearer.
src/serac/physics/base_physics.hpp
Outdated
| { | ||
| SLIC_ERROR_ROOT(axom::fmt::format("Adjoint analysis not defined for physics module {}", name_)); | ||
| if (string_to_bc.size()) { |
kswartz92
approved these changes
Dec 30, 2024
use not empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow some base physics interfaces to be used in cases where maps are empty to allow end users to use the common interface in more cases.