Update copyright year #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steven-Roberts
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
gardner48
requested changes
Jan 11, 2025
There was a problem hiding this comment.
Greping for '\-202[0-4]' finds a few files the update script misses:
doc/arkode/examples/source/conf.pyscripts/tarscriptscripts/cvodescripts/sharedscripts/cvodesscripts/idascripts/arkodescripts/idasscripts/kinsolscripts/cvodes
The files under external/sundials-addon-example also need to be updated but they are in a submodule and the actual files are here.
This also revealed a few source files that got added to test/answers accidentally. I've opened sundials-codes/answers#45 to remove them.
There is also scripts/spack but Spack recently removed years from their Copyright lines in favor of Copyright (c) Spack Project Developers. (see spack/spack#48352).
Discussion topic for later, maybe we should also remove the years in our files.
|
I'd be in favor of removing it. I'll make a note to discuss Tuesday. |
gardner48
reviewed
Jan 21, 2025
This was referenced Jan 22, 2025
gardner48
pushed a commit
to sundials-codes/answers
that referenced
this pull request
Jan 22, 2025
gardner48
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a couple dozen files had copyright end data <2024. I guess those were from PRs that started in one year but were merged the next. There are probably a few situations like that now, e.g., ERK adjoint, where we'll need to run the update copyright script.