From 331f137b61afca9efa0cb6ed97418eadd672ffed Mon Sep 17 00:00:00 2001 From: "David J. Gardner" Date: Mon, 9 Sep 2024 18:22:46 -0700 Subject: [PATCH 1/3] fix bug in setting IMEX-MRI methods --- src/arkode/arkode_mristep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arkode/arkode_mristep.c b/src/arkode/arkode_mristep.c index 0989e43a7c..286a4390e8 100644 --- a/src/arkode/arkode_mristep.c +++ b/src/arkode/arkode_mristep.c @@ -1759,8 +1759,8 @@ int mriStep_SetCoupling(ARKodeMem ark_mem) { case 1: table_id = MRISTEP_DEFAULT_IMEX_SD_1; break; case 2: table_id = MRISTEP_DEFAULT_IMEX_SD_2; break; - case 3: table_id = MRISTEP_DEFAULT_IMEX_SD_2; break; - case 4: table_id = MRISTEP_DEFAULT_IMEX_SD_2; break; + case 3: table_id = MRISTEP_DEFAULT_IMEX_SD_3; break; + case 4: table_id = MRISTEP_DEFAULT_IMEX_SD_4; break; } /**** implicit methods ****/ From 3350af4955999fbb30ad1c2da8602048c1f8e6a2 Mon Sep 17 00:00:00 2001 From: "David J. Gardner" Date: Mon, 9 Sep 2024 18:32:20 -0700 Subject: [PATCH 2/3] update recent changes --- CHANGELOG.md | 4 ++++ doc/shared/RecentChanges.rst | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3a82dd8621..2d90a7edfd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,10 @@ architecture for their system. Fixed the loading of ARKStep's default first order explicit method. +Fixed loading the default IMEX-MRI method if ``ARKodeSetOrder`` is used to +specify a third or fourth order method. Previously, the default second order +method was loaded in both cases. + Fixed a CMake bug regarding usage of missing "print_warning" macro that was only triggered when the deprecated `CUDA_ARCH` option was used. diff --git a/doc/shared/RecentChanges.rst b/doc/shared/RecentChanges.rst index 0cd3986ee3..04d534e295 100644 --- a/doc/shared/RecentChanges.rst +++ b/doc/shared/RecentChanges.rst @@ -12,6 +12,10 @@ override this value with the architecture for their system. Fixed the loading of ARKStep's default first order explicit method. +Fixed loading the default IMEX-MRI method if :c:func:`ARKodeSetOrder` is used to +specify a third or fourth order method. Previously, the default second order +method was loaded in both cases. + Fixed a CMake bug regarding usage of missing "print_warning" macro that was only triggered when the deprecated ``CUDA_ARCH`` option was used. From 305df0a76d2b35c6699d4f95a446e8e55a9c6289 Mon Sep 17 00:00:00 2001 From: "David J. Gardner" Date: Mon, 9 Sep 2024 18:34:01 -0700 Subject: [PATCH 3/3] single quotes in markdown --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d90a7edfd..85706f6f2c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,7 @@ architecture for their system. Fixed the loading of ARKStep's default first order explicit method. -Fixed loading the default IMEX-MRI method if ``ARKodeSetOrder`` is used to +Fixed loading the default IMEX-MRI method if `ARKodeSetOrder` is used to specify a third or fourth order method. Previously, the default second order method was loaded in both cases.