Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Map server crash when fighting #6725

Open
3 tasks done
HaxleyMODS opened this issue Jan 15, 2025 · 23 comments
Open
3 tasks done

🐛 Map server crash when fighting #6725

HaxleyMODS opened this issue Jan 15, 2025 · 23 comments
Labels
bug Something isn't working

Comments

@HaxleyMODS
Copy link

HaxleyMODS commented Jan 15, 2025 •
edited by Xaver-DaRed
Loading

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows10

Branch affected by issue

base

Steps to reproduce

Fight any mob. TP moves affecting multiple players crashes the map server.
resistanceerror

Expected behavior

Map not crashing
@HaxleyMODS HaxleyMODS added the bug Something isn't working label Jan 15, 2025
@HaxleyMODS
Copy link
Author

example2

Another example relating to this bug, this time is the players wyvern breath.

Appears to affect everything relating to Magic_Hit_Rate.

@WinterSolstice8
Copy link
Member

I don't get those lua errors as of head (72170d4)
But I did manage to produce a crash, standby

@WinterSolstice8 WinterSolstice8 mentioned this issue Jan 15, 2025
Merged
4 tasks
@Xaver-DaRed
Copy link
Contributor

Those log errors were fixed over 24 hours ago and the crash is probably unrelated. Gonna edit the issue title.

@Xaver-DaRed Xaver-DaRed changed the title 🐛 New Magic_Hit_Rate changes throw errors and crash map 🐛 Map crash when fighting Jan 15, 2025
@Xaver-DaRed Xaver-DaRed changed the title 🐛 Map crash when fighting 🐛 Map server crash when fighting Jan 15, 2025
@HaxleyMODS
Copy link
Author

Is there anything else I can do to provide information related to the crashing?

@WinterSolstice8
Copy link
Member

General found another one that I made a PR for here #6730

@HaxleyMODS
Copy link
Author

I should close this now, correct?

@WinterSolstice8
Copy link
Member

I think your issue may not have been related, but i'd close if you can't repro after #6730 is merged

@HaxleyMODS
Copy link
Author

No worries, just waiting for the checks to finish/ merge to happen and I'll rebuild immediately to try and get you updated

@BoundingS
Copy link

BoundingS commented Jan 16, 2025 •
edited
Loading

No worries, just waiting for the checks to finish/ merge to happen and I'll rebuild immediately to try and get you updated

I updated to current build this morning and now get this:

Image

Related? Reproduced 3x in a row, different trusts, 1 trust etc.

@WinterSolstice8
Copy link
Member

Yeah, could be related.

I'll make a PR to audit use of m_errorMsg more specifically

@WinterSolstice8 WinterSolstice8 mentioned this issue Jan 16, 2025
Merged
4 tasks
@BoundingS
Copy link

BoundingS commented Jan 16, 2025 •
edited
Loading

Yeah, could be related.

I'll make a PR to audit use of m_errorMsg more specifically

I don't know if this is helpful for you or not, but I figure it can't hurt. For 1, since I posted this earlier today I have been told by others they are not reproducing. The 2nd thing is I noticed that every file and line referenced in my crash reports have 2 things in common: they all seem to either reference mobskills in some way or a listener for them, or ticks. I went to every line to read them and noticed that. 5 of those files were changed yesterday but since others are not reproducing I will rebuild again from scratch to double check.

@WinterSolstice8
Copy link
Member

Yeah i'm not really sure why you'd still have those errors myself. Just as a general note, lua errors/log message don't always directly correlate with the real crashes. The wheaty crash dump (if one is generated) will actually tell you whats wrong

@HaxleyMODS
Copy link
Author

HaxleyMODS commented Jan 17, 2025 •
edited
Loading

Still getting an unknown map crash; From crash log:

!!! CRASH !!!
Exception code: C0000005 (ACCESS_VIOLATION)
Fault address: 00007FFDEA74B699 01:000000000003A699
Process: Map.exe
Time of crash: 2025/01/16 19:44:00
Process Uptime: 23 minutes
Processor: Intel(R) Core(TM) i5-6400 CPU @ 2.70GHz
Number Of Threads: 4
OS: Windows 10 Professional (Version 10.0, Build 19045)
Process Memory Usage: 1894MiB / 16384MiB
System Memory Usage: 5595MiB / 16287MiB
Git Branch: base
Git Commit Subject: Merge pull request #6734 from LandSandBoat/chore/useless-comments
Git SHA: 855a424-dirty
Git Date: Thu Jan 16 11:20:50 2025

=== Backtrace ===
CZoneEntities::ZoneServer: NPC: Ramblix (17404404)
CZoneEntities::ZoneServer: NPC: Goblin_Footprint (17404405)
CZoneEntities::ZoneServer: NPC: Planar_Rift (17404406)
CZoneEntities::ZoneServer: NPC: Planar_Rift (17404407)
CZoneEntities::ZoneServer: NPC: Planar_Rift (17404408)
CZoneEntities::ZoneServer: NPC: Riftworn_Pyxis (17404409)
CZoneEntities::ZoneServer: NPC: Riftworn_Pyxis (17404410)
CZoneEntities::ZoneServer: NPC: Riftworn_Pyxis (17404411)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404412)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404413)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404414)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404415)
CZoneEntities::ZoneServer: NPC: Geomagnetic_Fount (17404416)
CZoneEntities::ZoneServer: NPC: HomePoint#1 (17404417)
CZoneEntities::ZoneServer: NPC: Ethereal_Junction (17404423)
CZoneEntities::ZoneServer: Trust: arciela_ii (17405952)

=== Call stack ===
Address Frame Function
00007FFDEA74B699 0000005DD0BFF450 RaiseException+69 ()
00007FFDEA4E2438 0000005DD0BFF490 _invalid_parameter_noinfo+C8 ()
00007FFDEA4E2379 0000005DD0BFF4D0 _invalid_parameter_noinfo+9 ()
00007FFDEA531784 0000005DD0BFF550 raise+E4 ()

@WinterSolstice8
Copy link
Member

Still getting an unknown map crash; From crash log:
...

There should be more to that file than just that. If there isn't build in debug mode and the next time it crashes there should be more info

@HaxleyMODS
Copy link
Author

After the latest build I also started getting watchdog timeouts; New crash report incoming before long.

@HaxleyMODS
Copy link
Author

New crash report post debug rebuild:

!!! CRASH !!!
Exception code: C0000005 (ACCESS_VIOLATION)
Fault address: 00007FFDD460FD8D 01:000000000001ED8D
Process Name: xi_map.exe
Time of crash: 2025/01/16 20:15:25
Process Uptime: 6 minutes
Processor: Intel(R) Core(TM) i5-6400 CPU @ 2.70GHz
Number Of Threads: 4
OS: Windows 10 Professional (Version 10.0, Build 19045)
Process Memory Usage: 4457MiB / 16384MiB
System Memory Usage: 8413MiB / 16287MiB
Git Branch: base
Git Commit Subject: Merge pull request #6734 from LandSandBoat/chore/useless-comments
Git SHA: 855a424-dirty
Git Date: Thu Jan 16 11:20:50 2025

=== Backtrace ===
CZoneEntities::ZoneServer: NPC: Ramblix (17404404)
CZoneEntities::ZoneServer: NPC: Goblin_Footprint (17404405)
CZoneEntities::ZoneServer: NPC: Planar_Rift (17404406)
CZoneEntities::ZoneServer: NPC: Planar_Rift (17404407)
CZoneEntities::ZoneServer: NPC: Planar_Rift (17404408)
CZoneEntities::ZoneServer: NPC: Riftworn_Pyxis (17404409)
CZoneEntities::ZoneServer: NPC: Riftworn_Pyxis (17404410)
CZoneEntities::ZoneServer: NPC: Riftworn_Pyxis (17404411)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404412)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404413)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404414)
CZoneEntities::ZoneServer: NPC: Grounds_Tome (17404415)
CZoneEntities::ZoneServer: NPC: Geomagnetic_Fount (17404416)
CZoneEntities::ZoneServer: NPC: HomePoint#1 (17404417)
CZoneEntities::ZoneServer: NPC: Ethereal_Junction (17404423)
CZoneEntities::ZoneServer: Trust: arciela_ii (17405952)

=== Call stack ===
Address Frame Function
00007FFDD460FD8D 00000063FB92B580 memmove+17D ()
00007FF7E78DF1F9 00000063FB92B5D0 CBasicPacket::CBasicPacket+79 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\packets\basic.h, line 65)
00007FF7E78E1286 00000063FB92B660 CBasicPacket::copy+26 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\packets\basic.h, line 89)
00007FF7E78EE4A6 00000063FB92B990 CMagicState::CMagicState+376 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\states\magic_state.cpp, line 55)
00007FF7E790F573 00000063FB92C140 CAIContainer::ChangeState<CMagicState,CBattleEntity * &,unsigned short &,enum SpellID &>+333 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\ai_container.h, line 160)
00007FF7E790A86F 00000063FB92C1A0 CAIContainer::Internal_Cast+BF (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\ai_container.cpp, line 233)
00007FF7E787F5C2 00000063FB92C1E0 CController::Cast+52 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\controllers\controller.cpp, line 49)
00007FF7E7881283 00000063FB92C220 CMobController::Cast+53 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\controllers\mob_controller.cpp, line 1300)
00007FF7E789A6A2 00000063FB92C330 CTrustController::Cast+1E2 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\controllers\trust_controller.cpp, line 520)
00007FF7E78AFCF5 00000063FB92D150 gambits::CGambitsContainer::Tick+E05 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\helpers\gambits_container.cpp, line 430)
00007FF7E789B220 00000063FB92D2E0 CTrustController::DoCombatTick+7A0 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\controllers\trust_controller.cpp, line 213)
00007FF7E789A347 00000063FB92D330 CTrustController::Tick+E7 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\controllers\trust_controller.cpp, line 106)
00007FF7E790B519 00000063FB92D4A0 CAIContainer::Tick+389 (C:\Users\HaxTV\Desktop\Primavista\server\src\map\ai\ai_container.cpp, line 441)
00007FF7E84E781A 00000063FB92EF10 CZoneEntities::ZoneServer+1CBA (C:\Users\HaxTV\Desktop\Primavista\server\src\map\zone_entities.cpp, line 1663)
00007FF7E850B6DF 00000

@WinterSolstice8
Copy link
Member

WinterSolstice8 commented Jan 17, 2025 •
edited
Loading

I dont think you have this commit:
56cf643
can you check?

can use git show 56cf6437ee0f22cd5f420529a2f7d62241edf658 in the CLI

@HaxleyMODS
Copy link
Author

I don't, that merge wasn't ready at the time of my last update (after 6730)

@WinterSolstice8
Copy link
Member

rebase, should fix that crash

@HaxleyMODS
Copy link
Author

Will update as soon as I can, doing that now

@Xaver-DaRed
Copy link
Contributor

Xaver-DaRed commented Jan 17, 2025 •
edited
Loading

As a general rule, before commenting or opening issues, be sure you can reproduce with the most recent and clean copy of the code, please.

@BoundingS
Copy link

looks like the fixes today have worked on this issue, trusts fighting as expected now :) Thank you Thank you!

@WinterSolstice8
Copy link
Member

thanks for the followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Xaver-DaRed @WinterSolstice8 @HaxleyMODS @BoundingS