Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitter off bug on promise tracker HOC #86

Open
brauliodiez opened this issue Mar 5, 2020 · 0 comments
Open

Emitter off bug on promise tracker HOC #86

brauliodiez opened this issue Mar 5, 2020 · 0 comments
Assignees

Comments

@brauliodiez
Copy link
Member

This issue was fixed on the hook version, in the HOC seems not to be fixed:

 componentWillUnmount() {
    emitter.off(promiseCounterUpdateEventId);
 }

We have two options to fix this:

  • Fix the HOC version.
  • Make the HOC version to use internally the hooks version.

The second version could be the cleanest one, we didn't use it in the past just in case somebody was using an older React version to let them use this by copy pasting, IMHO now it doesn't makes sense.

I would go for the second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants