Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selfh.st/icons support #1786

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add selfh.st/icons support #1786

wants to merge 5 commits into from

Conversation

LinuxSBC
Copy link

@LinuxSBC LinuxSBC commented Jan 9, 2025

LinuxSBC Medium LinuxSBC /master → Lissy93/dashy Commits: 5 | Files Changed: 6 | Additions: 21 Label Unchecked Tasks Powered by Pull Request Badge

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Feature

Overview

Briefly outline your new changes...

Added an icon provider for selfh.st icons, which is a popular and large repository of icons for self-hosted and other applications.

Issue Number (if applicable) N/A

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here

I don't know if this counts as a config option, but I added support for icons prefixed with sh-, such as icon: sh-home-assistant.

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@LinuxSBC LinuxSBC requested a review from Lissy93 as a code owner January 9, 2025 04:47
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 88a6c22
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/677f54fe99812e00080de6db
😎 Deploy Preview https://deploy-preview-1786--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants