Skip to content

Latest commit

 

History

History
55 lines (35 loc) · 1.94 KB

contributing.md

File metadata and controls

55 lines (35 loc) · 1.94 KB

Contributing to Lucca Front

We use english.

Questions or Problems?

Post a message on slack.

Issues or Bugs

Create an issue on Github.

You can also post a message on slack.

Coding Rules

Icons

Follow our tutorial on Notion (🇫🇷)

SCSS files

Follow our tutorial on Prisme (🇫🇷)

🚧 TODO directory structure

Angular

🚧 TODO with the frontend guild

Submission Guidelines

Submitting a Pull Request (PR)

  1. Prefix the PR title with the name of the component: [{ComponentName}] A short description
  2. When a component, an icon or an scss class is added or modified, check the following: - Stories are updated or created: Check the documentation in the stories and update if necessary. - Unit tests are updated or created for ng components. - 🚧 UiDiff.
  3. Add a label "Technical", "Feature" or "Issue".
  4. Add a label "Documentation changes" when a stories is added or modified.
  5. Check the build before posting the PR on slack.

Submitting an issue or a feature

  1. Add a Github issue.
  2. Add a label "Feature" or "FIX".
  3. Add the appropriate labels ("Front", "Design sync"…).
  4. Create a branch from the "rc" branch for the current milestone, or from the tag version when a bug target a specific version. For a bug, specify all versions impacted.