-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapters to implement #4
Comments
I think "AWS buckets" is referred to S3 normally. We can look at what Flysystem supports, but I like GCS (Google Cloud Storage) personally and as I mentioned, memory (as well as local). Flysystem has a bunch. I think local and S3 is enough to go public. I would prefer to add adapters as people need (and encourage people to write them) as opposed to maintaining everything. |
I couldn't remember if s3 was right or something else - its been a long day :p I guess its fair to not include dropbox out of the box because people don't really use it as a CDN in my experience |
We should also discuss how to handle authentication |
What do you mean? Each adapter would definitely have different constructor parameters. In S3's case, you pass in your AWS creds and a bucket name. We shouldn't need to handle auth. |
I was thinking that it would be part of the core, but considering everything will be so different you're probably right in that it would be part of the adapter. |
Dropbox
aws buckets
??
The text was updated successfully, but these errors were encountered: