Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapters to implement #4

Closed
jmartin84 opened this issue Dec 23, 2016 · 6 comments
Closed

Adapters to implement #4

jmartin84 opened this issue Dec 23, 2016 · 6 comments

Comments

@jmartin84
Copy link
Contributor

Dropbox
aws buckets
??

@CWSpear
Copy link
Collaborator

CWSpear commented Dec 23, 2016

I think "AWS buckets" is referred to S3 normally.

We can look at what Flysystem supports, but I like GCS (Google Cloud Storage) personally and as I mentioned, memory (as well as local).

Flysystem has a bunch. I think local and S3 is enough to go public. I would prefer to add adapters as people need (and encourage people to write them) as opposed to maintaining everything.

@jmartin84
Copy link
Contributor Author

I couldn't remember if s3 was right or something else - its been a long day :p

I guess its fair to not include dropbox out of the box because people don't really use it as a CDN in my experience

@jmartin84
Copy link
Contributor Author

We should also discuss how to handle authentication

@CWSpear
Copy link
Collaborator

CWSpear commented Dec 23, 2016

What do you mean? Each adapter would definitely have different constructor parameters. In S3's case, you pass in your AWS creds and a bucket name. We shouldn't need to handle auth.

@jmartin84
Copy link
Contributor Author

I was thinking that it would be part of the core, but considering everything will be so different you're probably right in that it would be part of the adapter.

@CWSpear
Copy link
Collaborator

CWSpear commented Dec 30, 2016

If you think of more adapters we want to add, open a new ticket, add the requested adapter and task labels. See #15 as an example. If #11 is still open, add the note about that, like #15.

@CWSpear CWSpear closed this as completed Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants