Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release volcalc 2.1.2 (first CRAN release) #98

Closed
19 of 22 tasks
Aariq opened this issue Jan 31, 2024 · 4 comments · Fixed by #99
Closed
19 of 22 tasks

Release volcalc 2.1.2 (first CRAN release) #98

Aariq opened this issue Jan 31, 2024 · 4 comments · Fixed by #99
Assignees
Labels
🛑 blocked Can't proceede until something else is resolved

Comments

@Aariq
Copy link
Collaborator

Aariq commented Jan 31, 2024

First release:

Prepare for release:

  • git pull
  • run vignettes/precompute.R script to precompute KEGG vignette
  • usethis::use_github_links()
  • urlchecker::url_check()
  • devtools::build_readme()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • git push

Submit to CRAN:

  • usethis::use_version('patch')
  • Increment version in CITATION.cff and CITATION
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
@Aariq Aariq changed the title Release volcalc 2.1.2 Release volcalc 2.1.2 (first CRAN release) Jan 31, 2024
@Aariq Aariq self-assigned this Jan 31, 2024
@Aariq
Copy link
Collaborator Author

Aariq commented Feb 1, 2024

@KristinaRiemer let's go over the first part of this checklist and finish up the rest together some time.

@Aariq Aariq mentioned this issue Feb 1, 2024
@Aariq Aariq linked a pull request Feb 2, 2024 that will close this issue
@Aariq Aariq closed this as completed in #99 Feb 15, 2024
@Aariq Aariq reopened this Feb 15, 2024
@Aariq
Copy link
Collaborator Author

Aariq commented Feb 21, 2024

pre-test on CRAN submission gave the following error on Debian r-devel:

  • checking package dependencies ... ERROR
    Package required but not available: ‘ChemmineOB’

Confirmed that ChemmineOB can be installed on rocker/r-devel.

Added a note to cran-comments.md and re-submitted. If pre-test fails again, then probably need to put ChemmineOB in Suggests.

@Aariq
Copy link
Collaborator Author

Aariq commented Feb 23, 2024

Failed again, so working on moving ChemmineOB to suggests and all the related changes (#101 #102)

@Aariq Aariq added the 🛑 blocked Can't proceede until something else is resolved label Feb 23, 2024
@Aariq
Copy link
Collaborator Author

Aariq commented Feb 28, 2024

This submission was rejected, partly due to the formatting of the License field in the DESCRIPTION of ChemmineOB. That has been fixed, but the fix hasn't hit Bioconductor yet. Closing this issue and will open a new one for a second attempt

@Aariq Aariq closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛑 blocked Can't proceede until something else is resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant