Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary preset-env #5

Open
ef4 opened this issue Apr 1, 2021 · 2 comments
Open

Unnecessary preset-env #5

ef4 opened this issue Apr 1, 2021 · 2 comments

Comments

@ef4
Copy link

ef4 commented Apr 1, 2021

This addon configures ember-auto-import to add babel preset-env for one package:

https://github.com/Mesitis/ember-form-validations/blob/master/index.js#L11

But this is the default behavior since ember-auto-import 1.5, which this addon is already using. So I think you can drop all that config. If you can't, please let me know why because I'm trying to audit what extensions to webpack config are truly needed by addons, and limit them to only that.

@niranjan94
Copy link
Contributor

Hi @ef4. Thanks for the tip. Let me try removing the configuration and get back to you.
This addon hasn't been updated in a while and is currently used only by a legacy app. So, will need to try removing the config and checking if all works okay.

@ef4
Copy link
Author

ef4 commented Apr 1, 2021

It's fine to leave it like this of course, I was just checking that there's not some bug in the built in behavior that requires this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants