Timing of embargo release

[sarahjeansweeney]

When users set an embargo for a file, they select the date the file will be made available (the release date). It appears that files are being released the day following the release date, not on the selected release date. For example, this record is set to be released today, October 23:

This item is under embargo and its content will be available for download and viewing on October 23, 2018

But, the embargo message still displays and the file is not available for download. The file should be made available for download on the day selected for the embargo release date.

[dgcliff]

Looking at the Solr code it appears to be a matter of range inclusion/exclusion logic. I'll work on a patch.

[dgcliff]

Actually looking at the solr doc, embargo is set at end of day instead of beginning of day

2018-10-23T23:59:59Z

Should be an easy fix