Skip to content
This repository has been archived by the owner on Apr 8, 2021. It is now read-only.

Pending items on Course View page #44

Open
ishanivardhan opened this issue Oct 31, 2017 · 8 comments
Open

Pending items on Course View page #44

ishanivardhan opened this issue Oct 31, 2017 · 8 comments

Comments

@ishanivardhan
Copy link
Contributor

ishanivardhan commented Oct 31, 2017

As per original designs, it would be nice to have an entire Course Index listing on the right of every course activity view page but this needs quite a bit of work & time and hence will be pursued as a separate ticket towards the end if time permits OR in the next version

See below design for reference:
Original Course View design

cc: @cehwitham , @pro-paul

@ishanivardhan ishanivardhan self-assigned this Oct 31, 2017
@ishanivardhan ishanivardhan changed the title Course Index as right block listing on Course View page Course Index as right-side listing on Course View page Oct 31, 2017
@cehwitham
Copy link
Member

Thank you for the update @ishanivardhan. Could you share some of the complexities around why this will take lots of work please? I think as you say, it's sensible if we don't let this hold up the v1.0 release.

@ishanivardhan
Copy link
Contributor Author

Yes @cehwitham ,

  • Basically, the current course index listing logic cannot be picked up as is to serve the design. Possibly a separate function needs to be built that only has the bits we need as per the design and this could be tricky given the logic sits in various course renderer & course format renderer functions that needs to be extended or invoked in the right manner.

  • Style wise as well, as earlier tried in Course listing ticket, it's not very straightforward to make the sections expand-collapse the way it's in the design. Simply applying Nightingale classes as they are in header sub-menus doesn't make it work. So, need to check as to what combination of JS & PHP logic will we need once we have the markup in a separate function as mentioned in pt[1].

All of this needs to nicely be brought together that requires more time and a bit of trial-n-error first.

@penpadstudio
Copy link

As stated in requested review my feedback:

32232217-79e2e67a-be4f-11e7-922e-8d654d8611a1

Better to see if we can swap complete button for checkbox when we can

32232234-81a9db02-be4f-11e7-8e9c-7d61523d643d

Why is title blue? Should be black even if link. Again update checkbox styling when appropriate time or when you have discussed further with Harry. Also I will look into theory of Green button/Submit rule for pages. Possibly add spacing between buttons for short term goal.

32232237-823cde16-be4f-11e7-927f-84599a94f6c9

I will look into activities layouts for more refinement and iteration further down the line.

@ishanivardhan ishanivardhan changed the title Course Index as right-side listing on Course View page Pending items on Course View page Nov 1, 2017
@ishanivardhan
Copy link
Contributor Author

ishanivardhan commented Nov 24, 2017

As per feedback from @adamref , few things he suggested that could improvise Participant flow/experience:

  1. Mark complete & Mark incomplete buttons are both in green with just text change. Could do with background color change for one of them.
    @pro-paul - your input required. A change to make it checkbox is not advisable for now as this is part of a plugin, not theme. But you could suggest button color change that can be done via CSS.

  2. No easy way for Student to have overview of the entire unit once they are on an activity page. So, maybe a course index on left or right of each activity page.
    This was already raised n this issue above and part of original Paul’s design, so this can be given another shot now as other big tickets are over!

  3. The sections on right of Course listing page to have a border around them, be more boxed.
    @pro-paul - Your thoughts?

cc: @cehwitham

@penpadstudio
Copy link

If we change the buttons to the following visual format (similar to forums):
screen shot 2017-11-27 at 14 46 46

Then we can possibly keep the completion button in green above and aligned right temporarily.

Also thanks @adamref for the input on boxing the modules, maybe we can implement this in a more styled approach next version.

@ishanivardhan
Copy link
Contributor Author

@jdbrew , @cehwitham - Need your view on whether or not we should have course listing index on every course element page?

@jdbrew
Copy link

jdbrew commented Dec 11, 2017

@ishanivardhan Let's research it for post v1.

Seacole 1 had it and it wasn't a great experience and impacted load times and accessibility. No programme since has had it. We've tried to stick to the GDS principle of one thing per page. If we want to add it back in let's show that the new design evaluates well against needs without impacting the existing page needs.

@ishanivardhan
Copy link
Contributor Author

Fair enough! Thanks for your input @jdbrew .. I'll move this in Icebox and come back to it when we discuss post v1 sprint planning to take up on priority.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants