Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the regression test checks #647

Closed
hu5970 opened this issue Oct 25, 2023 · 4 comments · Fixed by #646
Closed

update the regression test checks #647

hu5970 opened this issue Oct 25, 2023 · 4 comments · Fixed by #646

Comments

@hu5970
Copy link
Collaborator

hu5970 commented Oct 25, 2023

Some of the regression test checks need to be updated or removed to better reflect the results of the regression tests.
such as maxmem and timing scalability tests.

Need to check and revise the following two files:

regression/regression_test.sh
regression/regression_test_enkf.sh
@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue Oct 25, 2023
Merged
8 tasks
@RussTreadon-NOAA
Copy link
Contributor

As reported in GSI PR #645, remove the maxmem and timing scalability tests from regression_test.sh and regression_test_enkf.sh. Rerun the seven ctests on Hera. All tests passed.

Hera(hfe03):/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr645/build$ ctest -j 7
Test project /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr645/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 7: global_enkf
    Start 4: netcdf_fv3_regional
    Start 3: rrfs_3denvar_glbens
    Start 5: hafs_4denvar_glbens
    Start 6: hafs_3denvar_hybens
1/7 Test #4: netcdf_fv3_regional ..............   Passed  491.83 sec
2/7 Test #3: rrfs_3denvar_glbens ..............   Passed  675.13 sec
3/7 Test #7: global_enkf ......................   Passed  949.82 sec
4/7 Test #6: hafs_3denvar_hybens ..............   Passed  2182.70 sec
5/7 Test #5: hafs_4denvar_glbens ..............   Passed  2308.16 sec
6/7 Test #2: rtma .............................   Passed  2474.11 sec
7/7 Test #1: global_4denvar ...................   Passed  3053.83 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 3053.84 sec

This is an expected result since PR #645 does not alter code, namelists, modules, or scripts.

@hu5970
Copy link
Collaborator Author

hu5970 commented Oct 25, 2023

Should we also remove the data, namelist, and scripts of the old cases that have been removed?
If so, we should create a special PR for this cleaning.

@RussTreadon-NOAA
Copy link
Contributor

Yes, removed ctests should have everything related to them removed. I did so in my Hera working copy of hafs-community:feature/hafs_rtcases. Feel free to look at what's been done in /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr645. We could expand the scope of PR #645 to include changes from this issue since PR #645 and this issue both involve regression test changes.

Once changes to remove old tests are merged into develop, I will remove the staged data for these tests from various machines.

@hu5970
Copy link
Collaborator Author

hu5970 commented Oct 25, 2023

Agree. Should we ask Jing to merge your Hera working copy: /scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr645 to her PR 645?

JingCheng-NOAA added a commit to hafs-community/GSI that referenced this issue Oct 26, 2023
@JingCheng-NOAA
clean up, optimize, and simplify regression tests (NOAA-EMC#600, NOAA…
ef6bd24 
…-EMC#647)
ShunLiu-NOAA pushed a commit that referenced this issue Oct 27, 2023
@JingCheng-NOAA
Feature/hafs rtcases (#646)
2cb0f5b 
Add HAFS related regression test into GSI Ctests to solve the issue
#600.

Four set of regression tests for the current suite of HAFSv1 GSI:

3DEnvar with GDAS Ensemble plus FGAT capability --
"hafs_3denvar_glbens".
4Denvar with GDAS Ensemble plus FGAT capability --
"hafs_4denvar_glbens".
3Envar with self-cycled HAFS Ensemble -- "hafs_3denvar_hafens".
3Envar with GDAS Ensemble plus self-cycled HAFS Ensemble --
"hafs_3denvar_hybens".

Fixes #600 
Partially fixes #647 

**Type of change**

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

**How Has This Been Tested?**

These changes are tested under Orion through GSI Ctests.
  
**Checklist**

- [x ] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] New and existing tests pass with my changes
- [x] Any dependent changes have been merged and published

**DUE DATE for this PR is 12/4/2023.** If this PR is not merged into
`develop` by this date, the PR will be closed and returned to the
developer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/hafs rtcases hafs-community/GSI
2 participants
@hu5970 @RussTreadon-NOAA