Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue building pre/post wave jobs with latest ufs-weather-model #3110

Closed
JessicaMeixner-NOAA opened this issue Nov 18, 2024 · 3 comments · Fixed by #3145
Closed

Issue building pre/post wave jobs with latest ufs-weather-model #3110

JessicaMeixner-NOAA opened this issue Nov 18, 2024 · 3 comments · Fixed by #3145
Assignees
@JessicaMeixner-NOAA @sbanihash
Labels
bug Something isn't working

Comments

@JessicaMeixner-NOAA
Copy link
Contributor

What is wrong?

FYI - There is an issue (seen here: #3106 (comment)) when building the wave model if you update to the latest ufs-weather-model. Fix for this is being tracked here: ufs-community/ufs-weather-model#2502

Just posting here so others know about this problem.

What should have happened?

WW3 pre/post jobs should build.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

adding newest ufs-weather-model

Steps to reproduce

Update ufs-weather-model to latest PR and try to build ww3 pre/post.

Additional information

No response

Do you have a proposed solution?

No response
@JessicaMeixner-NOAA JessicaMeixner-NOAA added bug Something isn't working triage Issues that are triage labels Nov 18, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

g-w is not using a UFS hash with this issue and the issue looks to be contained within UFS. Is there a reason we need a g-w issue for this (e.g. some change to the build script will be needed)?

@JessicaMeixner-NOAA
Copy link
Contributor Author

It's common for people to update the ufs-weather-model on their own - for example: #3106 therefore, communicating that this will be an issue seems like a good idea for everyone's awareness. Do you have a better method of communicating that this will be an issue?

@JessicaMeixner-NOAA
Copy link
Contributor Author

PR to ufs-weather-model to address this issue is here: ufs-community/ufs-weather-model#2512

Branch of g-w used to test is here: https://github.com/JessicaMeixner-NOAA/global-workflow/tree/bug/addPIOswitch
Note this does not enable to the pio for WW3 yet, but confirms we can get past build issues to enable that feature in the global-workflow.

Merged
16 tasks
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this issue Dec 6, 2024
Merged
22 tasks
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Dec 10, 2024
sbanihash pushed a commit to sbanihash/global-workflow that referenced this issue Dec 14, 2024
@JessicaMeixner-NOAA @sbanihash
Update ufs-weather-model to 2024-12-06 commit (NOAA-EMC#3145)
41972b6 
This PR updates ufs-weather-model hash to the latest commit which
addresses an issue seen in an earlier commit (see:
NOAA-EMC#3110)

Note this includes the PR that enables PIO for WW3, however additional
work is required to use this feature.
Another notable PR update is for a PIO finalize bug in CICE which also
required updates to ice_in

Resolves NOAA-EMC#3110
@aerorahul aerorahul added enhancement Add features that enhance capabilities of the system bug Something isn't working and removed bug Something isn't working enhancement Add features that enhance capabilities of the system labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessicaMeixner-NOAA JessicaMeixner-NOAA

@sbanihash sbanihash

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ufs-weather-model to 2024-12-06 commit JessicaMeixner-NOAA/global-workflow
4 participants
@aerorahul @JessicaMeixner-NOAA @WalterKolczynski-NOAA @sbanihash