Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Energy Losses to Represent ORCA's Losses Method #10

Open
11 tasks done
RHammond2 opened this issue Aug 22, 2024 · 1 comment · Fixed by #11
Open
11 tasks done

Update Energy Losses to Represent ORCA's Losses Method #10

RHammond2 opened this issue Aug 22, 2024 · 1 comment · Fixed by #11
Assignees
Labels
enhancement New feature or request

Comments

@RHammond2
Copy link
Collaborator

RHammond2 commented Aug 22, 2024

Currently the Project.energy_losses method incorrectly calculates the losses, and should replicate the ORCA model.

Steps to completion:

  • Change the Project.loss_ratio to Project.environmental_losses with a default of 0.0159
  • Rewrite Project.energy_losses to be of the form: 1 - [(1 - L_1) * (1 - L_2) … * (1 - L_n)] where we have:
    • environmental (user input)
    • availability (WOMBAT)
    • wake (FLORIS)
    • technical (new method based on ORCA)
      • potentially need a flag or input for land vs fixed vs floating substructure, such as project_type
    • electrical (new method using ORBIT parameters)
  • Expand Project.energy_losses to optionally provide the categorical breakout of each of the above loss categories
  • Update all references to Project.loss_ratio
  • Update documentation as needed to reflect the changes
@RHammond2 RHammond2 added the enhancement New feature or request label Aug 22, 2024
@dmulash
Copy link
Collaborator

dmulash commented Sep 4, 2024

  • I implemented individual methods for each loss type (excluding availability) using equations from the ORCA model, as well as a method for total losses. This allows for easy integration across different methods in project.py, particularly benefiting the capacity_factor function.
  • Since loss_ratio is used extensively across project.py, I opted to remove it entirely instead of replacing it with environmental_loss_ratio. Consequently, I updated the documentation and modified functions like energy_potential() to use the new total_loss_ratio() method.
  • I implemented changes in energy_potential() so that the net_capacity_factor is calculated using total_loss_ratio() instead of the old (and eliminated) loss_ratio

@RHammond2 RHammond2 linked a pull request Sep 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants