Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply #3621 #3714

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Reapply #3621 #3714

wants to merge 3 commits into from

Conversation

wujingyue
Copy link
Collaborator

No description provided.

@wujingyue
Copy link
Collaborator Author

!test

Copy link

github-actions bot commented Jan 16, 2025

PR Reviewer Guide 🔍

(Review updated until commit 1bee54d)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
⚡ Recommended focus areas for review

Logic Change

The cacheInputs function signature has been updated to include a new parameter propagate_allocation. This change may affect the behavior of the cacheInputsAndOutputs function in the AmpereMultipleMatmulScheduler class.

scheduler_utils::cacheInputs(
    fusion_, /*unroll=*/true, /*propagate_allocation=*/true);
Function Signature Change

The cacheInputs function signature has been updated to include a new parameter propagate_allocation. This change may affect the behavior of the function and its callers.

std::vector<TensorView*> cacheInputs(
    Fusion* fusion,
    bool unroll,
    bool propagate_allocation) {
Test Update

The test case InputAllocationIsSplit_Concrete has been updated to include a new line in->setLoopDomain(in->getLogicalDomain());. This change may affect the behavior of the test.

in->setLoopDomain(in->getLogicalDomain());

@wujingyue
Copy link
Collaborator Author

!test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant