monai_trainer.py and ignite API #865

vfdev-5 · 2022-09-08T14:46:51Z

vfdev-5
Sep 8, 2022

Line 174 in 88c9419

    
           # Unfortunately the ignite engine does not support the abort of task right now. We have to wait until

I was checking project's examples and have seen above comment. I wonder whether it is usage question or ignite is still missing a feature ? Thanks

Answered by YuanTingHsieh

Thanks for raising the discussion.

@yiheng-wang-nv did you write this line at that time? do you remember why you make this comment?

YuanTingHsieh · 2022-09-13T01:09:22Z

Thanks for raising the discussion.

@yiheng-wang-nv did you write this line at that time? do you remember why you make this comment?

4 replies

Thanks, @vfdev-5. This example will be replaced by one using Ignite's new API (available in 0.4.10) and MONAI's new FL components, i.e. MonaiAlgo.

@holgerroth does that mean we need to remove hello-monai here?

Yes, I think so. We already replaced the hello-monai-bundle in 2.2. https://github.com/NVIDIA/NVFlare/tree/2.2/examples/hello-monai-bundle but not in the dev branch. I will make the same change there and remove hello-monai