Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker job launcher provision #3116

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

docker job launcher provision #3116

wants to merge 6 commits into from
+140 −47

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Dec 17, 2024

Fixes # .

Description

Added docker job launcher configuration provision ability.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

yanchengnv
yanchengnv requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

nvflare/lighter/dummy_project.yml Outdated Show resolved Hide resolved
nvflare/lighter/ctx.py Outdated Show resolved Hide resolved
nvflare/lighter/dummy_project.yml Outdated Show resolved Hide resolved
nvflare/lighter/constants.py Outdated Show resolved Hide resolved
nvflare/lighter/impl/docker.py Outdated Show resolved Hide resolved
nvflare/lighter/impl/static_file.py Outdated Show resolved Hide resolved
yanchengnv
yanchengnv reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @IsaacYangSLA please review.

yanchengnv
yanchengnv previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhwen yhwen enabled auto-merge (squash) January 10, 2025 14:33
@yhwen
Copy link
Collaborator Author

yhwen commented Jan 10, 2025

/build

1 similar comment
@yhwen
Copy link
Collaborator Author

yhwen commented Jan 13, 2025

/build

yanchengnv
yanchengnv approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhwen
Copy link
Collaborator Author

yhwen commented Jan 14, 2025

/build

1 similar comment
@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator

/build

1 similar comment
@yhwen
Copy link
Collaborator Author

yhwen commented Jan 15, 2025

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhwen @YuanTingHsieh @yanchengnv