Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the build folder for unit test to ensure correctness #3143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Jan 15, 2025

Fix the occasionally issue in TestTaskScriptRunner

Description

Sometimes the unit test failed because there is a "build" dir, this will lead to test failure:

AssertionError: Lists differ: ['/ho[28 chars]VFlare-premerge/build/lib/nvflare/cli.py', '--batch_size', '4'] != ['/ho[28 chars]VFlare-premerge/nvflare/cli.py', '--batch_size', '4']

That build dir is generated by pip install and can be removed during the unit test phase to ensure correctness

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label Jan 15, 2025
@YuanTingHsieh
Copy link
Collaborator Author

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd continuous integration/continuous development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants