Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Azure OpenAi embedding model #692

Open
shubhiroy opened this issue Aug 22, 2024 · 6 comments
Open

Support for Azure OpenAi embedding model #692

shubhiroy opened this issue Aug 22, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@shubhiroy
Copy link

I'd like to propose adding support for the Azure OpenAI embedding model. My primary reason for this is to enable the use of the text-embedding-ada-002 model as the embedding model.

I believe this could be beneficial for those who are already using Azure's services or prefer to work within that ecosystem. I'm also happy to contribute to implementing this feature. Would there be any preference on how to integrate Azure OpenAI support? We could potentially add it in the configuration file, similar to other models.

  models:
    - type: main
      engine: openai
      model: text-davinci-003
   - type: embedding
     engine: azure
     model: text-embedding-ada-002
@drazvan
Copy link
Collaborator

drazvan commented Aug 22, 2024

Hi @shubhiroy! Thanks for offering to contribute to this. Should be very straightforward to add, very similar to https://github.com/NVIDIA/NeMo-Guardrails/blob/develop/nemoguardrails/embeddings/providers/openai.py.
And all the relevant code is in here: https://github.com/NVIDIA/NeMo-Guardrails/tree/develop/nemoguardrails/embeddings/providers.

Let me know if you need more guidance. Looking forward to your PR!

@drazvan drazvan added the enhancement New feature or request label Aug 22, 2024
@shubhiroy
Copy link
Author

Hi @drazvan,
Can you please review this pr? - #702

@Narayanan12345
Copy link

@shubhiroy and @drazvan - Could you please confirm if this feature is ready?

@ShubhiAbb
Copy link

Hi @Narayanan12345 , PR is still in pending state. Waiting for some reviewer to merge it.

@Pouyanpi
Copy link
Collaborator

Pouyanpi commented Jan 9, 2025

@Narayanan12345 , @ShubhiAbb , @shubhiroy

There is a conflict with dev branch that needs to be resolved by @shubhiroy once the conflict is resolved I'll merge.

@ShubhiAbb
Copy link

@Narayanan12345 , @ShubhiAbb , @shubhiroy

There is a conflict with dev branch that needs to be resolved by @shubhiroy once the conflict is resolved I'll merge.

@Pouyanpi - I will resolve it in this week. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants