Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blossom-ci.yaml #7

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Remove blossom-ci.yaml #7

merged 1 commit into from
Feb 1, 2024

Conversation

elezar
Copy link
Member

@elezar elezar commented Feb 1, 2024

No description provided.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar self-assigned this Feb 1, 2024
@elezar
Copy link
Member Author

elezar commented Feb 1, 2024

@ArangoGutierrez @mikemckiernan the actions around docker files need to be reworked too. Since we're just removing the blossom-ci in this PR the failures are definitely unrelated.

One thing I noticed is that the dockerfile-changed job should probably just use the docker login action instead of logging in manually.

      - name: Log in to Container Registry
        uses: docker/login-action@v2
        with:
          registry: ${{ env.REGISTRY }}
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}

@elezar elezar merged commit 4afe42c into NVIDIA:main Feb 1, 2024
3 of 5 checks passed
@elezar elezar deleted the cleanup-actions branch February 1, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants