Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate parameters with stopping criterion to allow stateful CLI parsing and improved diagnostics #153

Open
alliepiper opened this issue Jan 9, 2024 · 0 comments

Comments

@alliepiper
Copy link
Collaborator

The custom stopping criterion introduced in #151 stores all parameters for all criterion implementations in a single map. This requires that all parameters must be uniquely named across implementations along with degraded error handling capabilities while parsing CLI arguments.

Each instance of stopping_criterion should hold its own params map, and the CLI parser should check that any arguments relating to these criterion are valid for the selected implementation.

The existing stopping criterion parameters are all documented as follows: Applies to the most recent --benchmark, or all benchmarks if specified before any --benchmark arguments. The new stopping criterion framework should support this pattern as well to allow individual benchmarks to be run with different tolerances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant