Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows OS - Issue with scaling factor #249

Open
Nazariglez opened this issue Mar 3, 2023 · 4 comments
Open

Windows OS - Issue with scaling factor #249

Nazariglez opened this issue Mar 3, 2023 · 4 comments

Comments

@Nazariglez
Copy link
Owner

From Olaroll on discord:

So in windows 10, if my scaling is set to 125%, I get an ugly jagged line like in the screenshots I posted. (other scaling factors probably have the issue as well)
Now it seems likely you wouldn't be able to just magically fix this, cause you can't just create detail in the image out of thin air.
I was hoping that the WindowConfig high_dpi option would help with this case, but it seems to do nothing.
Essentially I'd just like to have a window with a resolution that is unaffected by the system's high-dpi scaling, so that my image pixels nicely align with the screen pixels.

Test case: https://gist.github.com/Olaroll/89052bb9b8820cd3225f8a1f4cf611e6

@Olaroll
Copy link

Olaroll commented Mar 3, 2023

Oh, right. Forgot to make an issue for it 😅

@Nazariglez
Copy link
Owner Author

use notan::app::Color;
use notan::AppState;
use notan::draw::{CreateDraw, DrawConfig, DrawImages};
use notan::prelude::{Graphics, Texture, WindowConfig};

const WIDTH: i32 = 200;
const HEIGHT: i32 = 200;
const SLOPE: f32 = 0.83; // Try adjusting this for different aliasing patterns


#[derive(AppState)]
struct Program {
    texture: Texture,
}

fn main() -> Result<(), String> {
    let win = WindowConfig::new()
        .vsync(true)
        .high_dpi(false) // Doesn't make a difference?
        .resizable(false)
        .size(WIDTH, HEIGHT);

    notan::init_with(|gfx: &mut Graphics| {
        Program { texture: make_texture(gfx) }
    })
        .add_config(win)
        .add_config(DrawConfig)
        .draw(|gfx: &mut Graphics, this: &mut Program| {
            let mut draw = gfx.create_draw();
            draw.image(&this.texture);
            gfx.render(&draw);
        })
        .build()
}

fn make_texture(gfx: &mut Graphics) -> Texture {
    let mut data = vec![0; (WIDTH * HEIGHT * 4) as usize];
    let color = Color::WHITE.rgba_u8();

    let mut x_max = 0.0;
    for y in 0..HEIGHT {
        for x in 0..(x_max as i32).min(WIDTH) {
            let i = (y * WIDTH + x) as usize * 4;
            data[i..i+4].copy_from_slice(&color);
        }
        x_max += SLOPE;
    }

    gfx.create_texture()
        .from_bytes(&data, WIDTH, HEIGHT)
        .build()
        .unwrap()
}

Copy link

This issue is stale because it has been open for 1 year with no activity.

@github-actions github-actions bot added the stale Abandoned issue by inactivity label Apr 29, 2024
Copy link

This issue was closed because it has been inactive for 30 days since being marked as stale. Do not hesitate to open a new issue if you need it.

@Nazariglez Nazariglez reopened this May 30, 2024
@github-actions github-actions bot removed the stale Abandoned issue by inactivity label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants