Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignore_timestamps_error in OpenEphysRawIO #1351

Closed
alejoe91 opened this issue Nov 22, 2023 · 1 comment
Closed

Remove ignore_timestamps_error in OpenEphysRawIO #1351

alejoe91 opened this issue Nov 22, 2023 · 1 comment
Labels

Comments

@alejoe91
Copy link
Contributor

Describe the bug
In #1213 we added the option to ignore timestamps errors in the Open Ephys legacy format. However, it turns out that these discontinuities could be uneven across files, so it's not a good idea to jus ignore them.

Expected behaviour
A better solution would be to "fill in" the missing timestamps with zeros (or NaNs) at the get_signal_analog_chunk level, so that all data is at least aligned

@zm711
Copy link
Contributor

zm711 commented Feb 2, 2024

Fixed by #1387.

@zm711 zm711 closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants