Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inaccurate critical error for 2D SpikeEventSeries #550

Open
3 tasks done
stephprince opened this issue Jan 9, 2025 · 0 comments
Open
3 tasks done

[Bug]: Inaccurate critical error for 2D SpikeEventSeries #550

stephprince opened this issue Jan 9, 2025 · 0 comments
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users

Comments

@stephprince
Copy link
Contributor

stephprince commented Jan 9, 2025

What happened?

According to the nwb-schema, a SpikeEventSeries can have dimensions [num events, num samples] when it contains data from a single electrode. The other option is to have dimensions [num events, num channels, num samples] if it has data from multiple electrodes.

However if an NWB file contains a 2D SpikeEventSeries, the inspector will return a critical error that the second dimension does not match the length of electrodes:

0  CRITICAL
===========

0.0  createESandSES.nwb: check_electrical_series_dims - 'SpikeEventSeries' object at location '/acquisition/spikedata1'
       Message: The second dimension of data does not match the length of electrodes. Your data may be transposed.

I think the check should be updated to warn about potentially transposed data only if a SpikeEventSeries has 3 dimensions.

Operating System

macOS

Python Version

None

Were you streaming with ROS3?

None

Package Versions

Copy and paste your output here

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • Have you ensured this bug was not already reported?
  • To the best of your ability, have you ensured this is a bug within the code that checks the NWBFile, rather than a bug in the NWBFile reader (e.g., PyNWB or MatNWB)?
@stephprince stephprince added category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

No branches or pull requests

1 participant