Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You are missing a few legal semantic versions #109

Open
matentzn opened this issue Dec 21, 2023 · 2 comments
Open

You are missing a few legal semantic versions #109

matentzn opened this issue Dec 21, 2023 · 2 comments

Comments

@matentzn
Copy link
Contributor

          You are missing quite a bit here: https://semver.org/

Semantic Versioning is a standard which allows versions like these:

  • 1.0.0-alpha
  • 1.0.0-alpha+001
  • 1.0.0+20130313144700
  • 1.0.0-beta+exp.sha.5114f85

I would suggest we use the official semver regex: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string

Originally posted by @matentzn in #105 (comment)

@anitacaron
Copy link
Collaborator

If I add the optional point to include the CHEBI version, the date (YYYY-MM-DD) will also match this pattern, and the test to not have both will fail for all. I already tried that.

@matentzn
Copy link
Contributor Author

What you re saying is a problem with the testing logic - not the matching. All of these semvar variants should be "allowed".. I just want to make sure that they are, independent of the CHEBI issue. right now, can you have 1.0.0-alpha+001 as the "version" part of the PURL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants