Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add d2p and g2p files here? #681

Open
drseb opened this issue Aug 25, 2020 · 8 comments
Open

Add d2p and g2p files here? #681

drseb opened this issue Aug 25, 2020 · 8 comments

Comments

@drseb
Copy link
Member

drseb commented Aug 25, 2020

@matentzn or anybody else: do you think I can add the links to d2p and g2p files (something similar to go-gene-association files) at this place:

thanks for any help

@matentzn
Copy link
Contributor

This is a policy question; I would say yes, but better ask @cmungall. Note that when something is added to the yaml file it can never be removed.

@matentzn
Copy link
Contributor

So the question is: can we add non ontology artefacts logically belonging to our ontology as primary products in the yaml file like:

products:
- hp.owl: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/master/hp.owl
- hp.obo: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/master/hp.obo
- hp.json: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/master/hp.json
- hpao-d2p.tsv: uri

@matentzn
Copy link
Contributor

If you wanted to host the files on github, you of course dont need to do anything.. you could place them in a folder annotations and then the purl http://purl.obolibrary.org/obo/hp/annotations/hpao-d2p.tsv would work even without further configuration (because of the generic fallthrough).

@jamesaoverton
Copy link
Member

Please use a subdirectory or something, not products.

@matentzn
Copy link
Contributor

I agree, I guess the question was posed because of a need to redirect somewhere outside the fall through. But even that should be possible right?

You could do:

entries:
- prefix: /hpoa-d2p.tsv
  replacement: http://compbio.charite.de/hudson/job/hpo.ontology.uberpheno/lastStableBuild/artifact/data/out/hpoa.tsv

- prefix: /releases/
  replacement: https://raw.githubusercontent.com/obophenotype/human-phenotype-ontology/v

@jamesaoverton
Copy link
Member

Yes you can have multiple prefix entries. They are mtached in order, so just be careful.

But for a single file I would use exact not prefix, so exact: /hpoa-d2p.tsv

@matentzn
Copy link
Contributor

Thanks @jamesaoverton!

@drseb You want to give this a shot yourself? I will review it; or I can do it for you if you tell me what you want to link.

@drseb
Copy link
Member Author

drseb commented Aug 26, 2020

@matentzn I will DM you regarding a call to implement this asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants