Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEGG module completeness estimation is wrong #8

Open
FWittmers opened this issue Apr 10, 2023 · 1 comment
Open

KEGG module completeness estimation is wrong #8

FWittmers opened this issue Apr 10, 2023 · 1 comment

Comments

@FWittmers
Copy link

I have come across a problem in the way this package evaluates the completeness of KEGG pathway modules, given a number KOs, or something comparable. Specifically, this is referring to the function query_missingGenes_from_module.R, but might be present in some of the other KEGG-module related functions?

The issue arrises from how the functions splits modules into blocks, based on spaces:

### SEARCH BLOCKS ----
  block_defs  <- strsplit(DEFINITION[index], split = " ")[[1]]
  nBlocks     <- length(block_defs)

This problem does not arise with every module, instead, it only occurs in more complicates modules which have "nested" blocks (for lack of a better word). For example, module 2 (https://www.genome.jp/kegg-bin/show_module?M00002) leads to this issue. The function in this package comes up with 6 blocks, (nBlocks), while there is only 5 blocks, as to my understanding of KEGG module definitions. This also matches the 5 blocks assumed in KEGGmapper. It must have something to do with the above chunk ignoring the presence of "(" or ")", ie when spaces occur WITHIN a block, instead of separating a block.

This problem should lead to a systematic underestimation of the completeness of pathways, when it inflates the number of blocks in a module. Adjusting the way the blocks are split to only split actual blocks (spaces outside of any "(" or ")"; something that can be done with regex I guess) should solve this issue.

@asmvernon
Copy link
Collaborator

Thanks for flagging. Unfortunately this package is no longer being actively maintained.
Let me know if you'd be interested in contributing the fix to the package though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants