Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover after subprocess crashes/dies #21

Open
septatrix opened this issue Aug 18, 2024 · 6 comments
Open

Recover after subprocess crashes/dies #21

septatrix opened this issue Aug 18, 2024 · 6 comments

Comments

@septatrix
Copy link

When a subprocess of the browser crashes the behaviors can differ depending on which subprocess crashed, however, there is no mechanism to recover from this or show this to the user. Chromium for example shows the "Aww snap" page when something goes awry. Cog (another popular kiosk browser based on Webkit) has a flag --webprocess-failure=restart which automatically restarts crashed processes. Alternatively one can tell cog to exit and handle it manually.

qt-kiosk-browser has none of these mechanisms or indicators. We are currently investigating switching from cog to this project, however, having no way to gracefully recover (or at least be able to configure the whole browser to terminate) is currently a showstopper as some crashes are inevitable after a certain scale (and in some rare circumstances we have also seen out-of-memory kills which similarly lead to a browser without e.g. a render process)

@otavio
Copy link
Member

otavio commented Aug 19, 2024

I found the link below. Although we can't restart or load the page right now, it would be great if you could consider moving to our browser. We currently don't have any customers who need this feature, so please prepare a request for the scenario you want to support.

https://lists.qt-project.org/pipermail/qtwebengine/2016-March/000336.html

@septatrix
Copy link
Author

@otavio
Copy link
Member

otavio commented Aug 21, 2024

I subscribed to watch for any comments and feedback in the issue that you reported. I hope they send something back soon.

@otavio
Copy link
Member

otavio commented Aug 21, 2024

Have you tried to implement some workaround as suggested in the comment that I sent before?

@septatrix
Copy link
Author

Have you tried to implement some workaround as suggested in the comment that I sent before?

No, I have not worked with QT/QML and am not sure where I would put that code. The only reference to a QWebEngineView is in the QML file and I do not know how to add the handler to it as that must be done in C++(?)

@otavio
Copy link
Member

otavio commented Aug 22, 2024

I am confident that incorporating support for that feature will require two to three hours of work. Would you be open to discussing the financial investment required for this development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants