Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the license issue in cmake utils #250

Closed
PragmaTwice opened this issue Mar 31, 2024 · 1 comment
Closed

About the license issue in cmake utils #250

PragmaTwice opened this issue Mar 31, 2024 · 1 comment
Labels
doc 📒 Documentation Improvements or additions to documentation

Comments

@PragmaTwice
Copy link

PragmaTwice commented Mar 31, 2024

Describe the problem that you experienced

Hi pikiwidb maintainers,

I noticed that the cmake/utils.cmake [1] file has been directly copied from Apache Kvrocks [2] (BTW it's written by me).
However, the license header states that it is copyrighted by Qihoo, Inc. and licensed under the BSD license.
This contradicts the Apache-2.0 license of Apache Kvrocks.

Apache Kvrocks is a project licensed under Apache-2.0 and owned by ASF.
If you wish to use code from Apache Kvrocks, please ensure to include the ASF license header correctly.
Changing the license or copyright owner without permission from ASF is not permitted.

[1] https://github.com/OpenAtomFoundation/pikiwidb/blob/b7f075eb2381f72b40d9a15ed9ee7bf7e34644e9/cmake/utils.cmake
[2] https://github.com/apache/kvrocks/blob/bb665f6fc2de7cb1215240866d48e92adfed43b1/cmake/utils.cmake

Best,
Twice

cc @tedli

Enter the URL of the topic with the problem

No response

Describe what you were looking for in the documentation

No response

Describe the actions that led you to experience the problem

No response

Describe what you want to experience that would fix the problem

No response

Add a screenshot if that helps illustrate the problem

No response

If this problem caused an exception or error, please paste it here

No response

If the problem is browser-specific, please specify the device, OS, browser, and version

No response

Provide any additional information here in as much as detail as you can

No response

@PragmaTwice PragmaTwice added the 📒 Documentation Improvements or additions to documentation label Mar 31, 2024
@AlexStocks AlexStocks added the doc label Apr 7, 2024
@dingxiaoshuai123
Copy link
Collaborator

dingxiaoshuai123 commented Apr 7, 2024

Describe the problem that you experienced

Hi pikiwidb maintainers,

I noticed that the cmake/utils.cmake [1] file has been directly copied from Apache Kvrocks [2] (BTW it's written by me). However, the license header states that it is copyrighted by Qihoo, Inc. and licensed under the BSD license. This contradicts the Apache-2.0 license of Apache Kvrocks.

Apache Kvrocks is a project licensed under Apache-2.0 and owned by ASF. If you wish to use code from Apache Kvrocks, please ensure to include the ASF license header correctly. Changing the license or copyright owner without permission from ASF is not permitted.

[1] https://github.com/OpenAtomFoundation/pikiwidb/blob/b7f075eb2381f72b40d9a15ed9ee7bf7e34644e9/cmake/utils.cmake [2] https://github.com/apache/kvrocks/blob/bb665f6fc2de7cb1215240866d48e92adfed43b1/cmake/utils.cmake

Best, Twice

cc @tedli

Enter the URL of the topic with the problem

No response

Describe what you were looking for in the documentation

No response

Describe the actions that led you to experience the problem

No response

Describe what you want to experience that would fix the problem

No response

Add a screenshot if that helps illustrate the problem

No response

If this problem caused an exception or error, please paste it here

No response

If the problem is browser-specific, please specify the device, OS, browser, and version

No response

Provide any additional information here in as much as detail as you can

No response

As this file is imported from PR #20 which is useless now. We have delete it in #261. Thanks for your reminder.

We really appreciate your contribution to our project. Any issue/pr is welcome from you.

@KKorpse KKorpse closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc 📒 Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants