Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command sscan #263

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

hahahashen
Copy link
Contributor

add command SSCAN and test cases

@github-actions github-actions bot added Invalid PR Title ✏️ Feature New feature or request labels Apr 9, 2024
@hahahashen hahahashen changed the title add command SSCAN feat: add command SSCAN Apr 9, 2024
@hahahashen hahahashen closed this Apr 9, 2024
@hahahashen hahahashen changed the title feat: add command SSCAN feat: add command sscan Apr 9, 2024
@hahahashen hahahashen reopened this Apr 9, 2024
src/cmd_set.cc Outdated Show resolved Hide resolved
@hahahashen hahahashen requested a review from AlexStocks April 9, 2024 08:12
@hahahashen hahahashen closed this Apr 9, 2024
@hahahashen hahahashen reopened this Apr 9, 2024
src/cmd_set.cc Outdated
client->AppendArrayLenUint64(members.size());
for (const auto& member : members) {
client->AppendString(member);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了一个空行

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉了

src/cmd_set.cc Outdated Show resolved Hide resolved
AlexStocks
AlexStocks previously approved these changes Apr 9, 2024
@AlexStocks
Copy link
Contributor

image

ci 失败了,按照上面check 里 加号 建议部分,改进下吧

@hahahashen
Copy link
Contributor Author

ci check format相关的部分改完了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


The relevant parts of ci check format have been modified.

@AlexStocks AlexStocks merged commit 78e2744 into OpenAtomFoundation:unstable Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants