Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When some of the expriments data is missing? #67

Open
kexul opened this issue Oct 21, 2022 · 3 comments
Open

When some of the expriments data is missing? #67

kexul opened this issue Oct 21, 2022 · 3 comments

Comments

@kexul
Copy link

kexul commented Oct 21, 2022

Hi, I recently used this package to generate some statistical data, it failed when some of the molecules' experiment values were not provided. Is there a solution to this kind of data?

Error:

line 97, in generate_graph_from_results of wrangle.py
    node[1]["exp_DG"] = self.results["Experimental"][name].DG
KeyError: 'mol20'
@richardjgowers
Copy link
Contributor

Hi @kexul

Can you give a bit more context into what you were doing that failed?

@kexul
Copy link
Author

kexul commented Dec 4, 2022

Sure @richardjgowers, I'd like to use some intermediate molecules to bridge the complex perturbations when doing relative free energy calculations, these intermediate molecules do not have experiment value.

abcd

For example, this is an input CSV file for cinnabar:

# Experiment 
mol1, 1
mol2, 2
mol3, 3

# Calculate
mol1, mol2, -1
mol2, intermidiate_mol, 0.5
intermidiate_mol, mol3, 0.5
mol3, mol1, -2

Then the above error will occur.

@richardjgowers
Copy link
Contributor

hi @kexul see my comment here: #82 (comment)

this is something which will soon be supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants