Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum Python version to 3.10 #340

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Bump minimum Python version to 3.10 #340

merged 1 commit into from
Aug 22, 2024

Conversation

mattwthompson
Copy link
Contributor

No description provided.

@mattwthompson
Copy link
Contributor Author

Not sure what some of this is i.e.

=========================== short test summary info ============================
FAILED gufe/tests/test_ligandatommapping.py::TestLigandAtomMapping::test_key_stable - AssertionError: assert 'LigandAtomMa...cb9dca9beae49' == <GufeKey('Lig...29abaefdb5b')>
  
  - LigandAtomMapping-2c0aae226e3f69d2d1cf429abaefdb5b
  + LigandAtomMapping-c333723fbbee702c641cb9dca9beae49
FAILED gufe/tests/test_smallmoleculecomponent.py::TestSmallMoleculeComponent::test_key_stable - AssertionError: assert 'SmallMolecul...26135a9b7fbb6' == <GufeKey('Sma...a42b9080ff2')>
  
  - SmallMoleculeComponent-82d90fcdcbe76a4155b0ea42b9080ff2
  + SmallMoleculeComponent-51068a89f4793e688ee26135a9b7fbb6
= 2 failed, 513 passed, 23 skipped, 6 xfailed, 1 xpassed, 163 warnings in 37.29s =

@IAlibay
Copy link
Member

IAlibay commented Aug 22, 2024

Not sure what some of this is i.e.

=========================== short test summary info ============================
FAILED gufe/tests/test_ligandatommapping.py::TestLigandAtomMapping::test_key_stable - AssertionError: assert 'LigandAtomMa...cb9dca9beae49' == <GufeKey('Lig...29abaefdb5b')>
  
  - LigandAtomMapping-2c0aae226e3f69d2d1cf429abaefdb5b
  + LigandAtomMapping-c333723fbbee702c641cb9dca9beae49
FAILED gufe/tests/test_smallmoleculecomponent.py::TestSmallMoleculeComponent::test_key_stable - AssertionError: assert 'SmallMolecul...26135a9b7fbb6' == <GufeKey('Sma...a42b9080ff2')>
  
  - SmallMoleculeComponent-82d90fcdcbe76a4155b0ea42b9080ff2
  + SmallMoleculeComponent-51068a89f4793e688ee26135a9b7fbb6
= 2 failed, 513 passed, 23 skipped, 6 xfailed, 1 xpassed, 163 warnings in 37.29s =

Ah yeah, I saw that happen on our cron jobs earlier, looks like something changed upstream that made the gufe keys change.. It's not related to what is being done here, so I'm happy to just push this change through.

@IAlibay IAlibay merged commit 9515596 into OpenFreeEnergy:main Aug 22, 2024
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @IAlibay