Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register source_id PCMDI-AMIP-1-2-0 #87

Closed
durack1 opened this issue Jul 10, 2019 · 10 comments · Fixed by #88, #96 or #121
Closed

Register source_id PCMDI-AMIP-1-2-0 #87

durack1 opened this issue Jul 10, 2019 · 10 comments · Fixed by #88, #96 or #121

Comments

@durack1
Copy link
Collaborator

durack1 commented Jul 10, 2019

In preparation for the 1.2.0 - 187001-201906 update, the revised source_id needs to be registered. Some tweaks to https://github.com/PCMDI/amipbcs will also likely be required to conform with the new input4MIPs_required_global_attributes.json

        "PCMDI-AMIP-1-2-0":{
            "comment":"Based on Hurrell SST/sea ice consistency criteria applied to merged HadISST (1870-01 1981-10) & NCEP-0I2 (1981-11 to 2019-06)",
            "contact":"PCMDI ([email protected])",
            "dataset_category":"SSTsAndSeaIce",
            "further_info_url":"https://pcmdi.llnl.gov/mips/amip",
            "grid":"1x1 degree longitude x latitude",
            "grid_label":"gn",
            "institution":"Program for Climate Model Diagnosis and Intercomparison, Lawrence Livermore National Laboratory, Livermore, CA 94550, USA",
            "institution_id":"PCMDI",
            "nominal_resolution":"1x1 degree",
            "product":"observations",
            "references":"Taylor, K.E., D. Williamson and F. Zwiers, 2000: The sea surface temperature and sea ice concentration boundary conditions for AMIP II simulations. PCMDI Report 60, Program for Climate Model Diagnosis and Intercomparison, Lawrence Livermore National Laboratory, 25 pp. Available online: https://pcmdi.llnl.gov/report/pdf/60.pdf",
            "region":[
                "global_ocean"
            ],
            "release_year":"2018",
            "source":"PCMDI-AMIP 1.2.0: Merged SST based on UK MetOffice HadISST and NCEP OI2",
            "source_description":"Sea surface temperature and sea-ice datasets produced by PCMDI (LLNL) for the AMIP (DECK) experiment of CMIP6",
            "source_id":"PCMDI-AMIP-1-2-0",
            "source_type":"satellite_blended",
            "source_variables":[
                "areacello",
                "sftof",
                "siconc",
                "siconcbcs",
                "tos",
                "tosbcs"
            ],
            "source_version":"1.2.0",
            "target_mip":"CMIP",
            "title":"PCMDI-AMIP 1.2.0 dataset prepared for input4MIPs"
        }

Following example in #57 and #94

@durack1
Copy link
Collaborator Author

durack1 commented Jul 15, 2019

Add dataset_collection DOI entry, after changes @MartinaSt implemented the higher-level citation info, for PCMDI-AMIP-X this is https://cera-www.dkrz.de/WDCC/ui/cerasearch/cmip6?input=input4MIPs.CMIP6.CMIP.PCMDI or https://doi.org/10.22033/ESGF/input4MIPs.10449

@durack1
Copy link
Collaborator Author

durack1 commented Oct 24, 2019

Updated to reflect the 1.2.0 release will be the first for the 2019 year, with 1.1.6 (#94) as the final v1.1.x series

@durack1
Copy link
Collaborator Author

durack1 commented Nov 21, 2019

Will need to redefine the :mip_era = "CMIP6" ;, which may need a redefinition in the tables, see Tables/input4MIPs_Omon.json

Is it possible to define this in the input files CMOR/drive_input4MIPs_obs/bcs.json, or the registered content input4MIPs_source_id.json

Make sure to check groupId before writing data to /p!! (may have to consider using grp to test), e.g.

import grp
a = grp.getgrall()
for count,x in enumerate(a):
    print(count,x,type(x),x[0])

@durack1 durack1 reopened this Nov 21, 2019
@durack1
Copy link
Collaborator Author

durack1 commented Aug 26, 2021

@mauzey1 I am planning on writing some new data with a newly defined mip_era = CMIP6Plus.

In the table files we have e.g. input4MIPs_Omon.json

"mip_era":"CMIP6",

What is the best path forward to generate data with the new mip_era?

Would a change to

"mip_era":"CMIP6 CMIP6Plus",

work?

ping @taylor13

@taylor13
Copy link

I suspect as we move to new eras, the CMIP tables will evolve, so I think we will need to preserve the old .json table files with mip_era=CMIP6, and generate a new set, as needed, for CMIP6Plus. In these new tables, we would set mip_era to CMIP6Plus. I know in the current case, nothing is changing really, but we should think about the future and how we'll organize tables for new eras.

@durack1
Copy link
Collaborator Author

durack1 commented Aug 26, 2021

I'm of two minds about this, we have version control, so you can always just dial up a previous version. Accumulating dead repos/tables doesn't seem like a great idea either

@taylor13
Copy link

If we don't create a new set of tables for future eras, could we create an index pointing to the versions that were used in a particular era?

@durack1
Copy link
Collaborator Author

durack1 commented Aug 26, 2021

In some ways we already have that

Releases https://github.com/PCMDI/input4MIPs-cmor-tables/releases
PCMDI-AMIP-1-1-6
PCMDI-AMIP-1-1-5
PCMDI-AMIP-1-1-4
PCMDI-AMIP-1-1-3
PCMDI-AMIP-1-1-2
PCMDI-AMIP-1-1-1
PCMDI-AMIP-1-1-0

And tags https://github.com/PCMDI/input4MIPs-cmor-tables/tags

As input4MIPs is more continuous, building off the CMIP6 standards, I think we're good with that path. For CMIP7 for e.g. I am sure much will change, so a completely new repo would make sense

@durack1
Copy link
Collaborator Author

durack1 commented Aug 27, 2021

@mauzey1 no need to bother with my query above (#87 (comment)) - I have just tested adding mip_era = 'CMIP6Plus' to my source_id registrations, and this is picked up by CMOR and used - it appears to propagate through all instances of mip_era in directory paths, netcdf file attributes etc etc

@durack1
Copy link
Collaborator Author

durack1 commented Aug 28, 2021

@taylor13 I have just updated a pull request with updates to table etc files that allow CMIP6Plus data to be written, it'd be great to have a chat about these changes (viewable here) before these are merged and become the current version of the repo
210827_CMOR3-CMIP6PlusWorking.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants